Details viewer tab to display user content

neuroBazzi commented 1 year ago

They would like to have the option to upload PDF that would be displayed in the Details Viewer. The upload will take place through the experiment creation tab / edit info and the PDF will be displayed ideally with dark background and white font.

afonsobspinto commented 12 months ago

We will need to:

Add a new tab to the 'Add to experiment' dialog which allows us to update PDF's
Adapt the model and views to associate uploaded PDF files to experiments
Process the PDF to follow the style guideline (dark background). If I recall correctly we have a python script for this already
Adapt the Details Viewer tab to include this new PDFs. Assuming the same accordion style format

I would estimate something around

24 hours

Questions:

Opposed to the current PDF's, the ones uploaded won't be associated with a population but rather the experiment correct?

neuroBazzi commented 12 months ago

yes, all correct (also the answer to question 1). @zsinnema thoughts?

zsinnema commented 12 months ago

@afonsobspinto I think you are correct about linking the pdf to the experiment

afonsobspinto commented 11 months ago

Investigate why there are no PDF's showing up @afonsobspinto

D-GopalKrishna commented 10 months ago

@neuroBazzi Is there any sample for this PDF type?

neuroBazzi commented 10 months ago

@D-GopalKrishna yes we do have the one from last year, let's keep in mind it's a placeholder and that the user should be able to upload PDFs during experiment creation (or add them at a later stage). cc @afonsobspinto Electrophysiological properties of V2a interneurons in the lumbar spinal cord.pdf

afonsobspinto commented 10 months ago

@neuroBazzi can we assume / enforce that the PDFs are 1 page only? If not, how should the UI handle multiple page PDFs?

neuroBazzi commented 10 months ago

@afonsobspinto I would not assume they are one page (ie.e. we should add pagination) and yes, the UI should be able to handle multiple uploads

afonsobspinto commented 10 months ago

@syamace-metacell to create a new button ('Add details?) and the modal to associate a population and a category (one of Electrophysiological, Behaviour, I/O Mapping) to the pdf to be added. @Aiga115 to handle the UI @D-GopalKrishna to create a new attribute for the population custom pdfs and connect it to the details viewer

afonsobspinto commented 9 months ago

One thing that I realized, is that with the introduction of this feature we stopped showing the original pdfs, is that something we want? Aka, the details viewer will only show the user uploaded pdfs and not the default ones? cc @neuroBazzi

neuroBazzi commented 9 months ago

@afonsobspinto I am not sure I understand what you mean with original PDF, could you paste an example?

D-GopalKrishna commented 9 months ago

@neuroBazzi

Please correct me if I am wrong @afonsobspinto, but I think he means the ones already present, before the current integration with the upload PDF. Default ones for behavior, electrophysiology, and io_mapping.

neuroBazzi commented 9 months ago

@D-GopalKrishna thank you. @afonsobspinto no worries I re-uplaoded them manually. all good :-)

afonsobspinto commented 9 months ago

Correct @D-GopalKrishna . @neuroBazzi previously they were part of all experiments but the PDFs now are associated with a population per experiment.

In other words, this mean that if you uploaded a PDF into V3 residential population for experiment 1 it won't show in V3 residential population for experiment 2 (which makes sense to me).

So what you uploaded is most likely only visible for a specific experiment. We can look into ways to have 'residential' PDFs if that's something we need to provide. Let me know

MetaCell / salk-interactive-atlas

Details viewer tab to display user content #288