search

MetaFam / TheGame

The platform that MetaGame will be played on aka MetaOS - an open source framework for running decentralized societies. Currently featuring MyMeta Profiles, Dashboard & Quests
https://metagame.wtf
Other
128 stars 77 forks source link

Fix Chain Ids for QuestChains #1751

Closed dysbulic closed 1 month ago

dysbulic commented 1 month ago

Overview

What features/fixes does this PR include?

Downgrades ethers to v5 for compatibility with Quest Chains.

Specifically, when v5's Provider.isProvider() is called with a v6 Provider, it returns false, causing the contract loading to not work correctly.

Follow up Improvement Ideas

Quest Chains needs to be updated to ethers v6 (which was released almost two years ago) because v5 is incompatible with other libraries like the Ethereum Attestation Service.

Implementation

Most everything present in v6 was also present in v5, but the import paths are different.

Switched from BrowserProvider to Web3Provider which is roughly equivalent.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **the-game-web** | ⬜️ Ignored ([Inspect](https://vercel.com/metafamily/the-game-web/6rQkkpeWG6y9gApp7cE5rsawthfs)) | [Visit Preview](https://the-game-web-git-fix-chain-ids-metafamily.vercel.app) | | Jun 11, 2024 2:54am |
github-actions[bot] commented 1 month ago

Successfully undeployed the Preview of this Pull Request