search

MetaFam / metagame-wiki

Your collaborative guide to your journey into The MetaGame
https://wiki.metagame.wtf
19 stars 48 forks source link

Fix/dead link home #243

Closed jonathanprozzi closed 3 years ago

jonathanprozzi commented 3 years ago

This resolves issue #231 with the broken link in docs/how-does-it-work/phases-of-metagame

I added a Markdown link format for it [https://wiki.metagame.wtf/docs/home](https://wiki.metagame.wtf/docs/home)

In looking at my PR it seems like my Markdown formatting settings in VSCode are different than the ones used in the docs (the rendered result is still the same).

If this doesn't pass review because of that I can disable my Markdown linter -- I didn't catch that until looking at the PR.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/metafam/metagame-wiki/A3ndKZbS8dd121KtoPvZ27xsGAgW
✅ Preview: https://metagame-wiki-git-fix-dead-link-home-metafam.vercel.app

jonathanprozzi commented 3 years ago

@jonathanprozzi thank you for jumping on this so fast. 🍻 The ticket mentions a couple of other issues that ought to be resolved before we close the ticket off. Was there a reason for not addressing those also? image

Oh my mistake -- that was a misunderstanding -- I didn't realize those should have been part of the same issue. I can resolve those as well! Apologies on that one. I can do that within the next hour.

Should I cancel my PR and then add those items in and create a new PR?

luxumbra commented 3 years ago

@jonathanprozzi thank you for jumping on this so fast. beers The ticket mentions a couple of other issues that ought to be resolved before we close the ticket off. Was there a reason for not addressing those also? image

Oh my mistake -- that was a misunderstanding -- I didn't realize those should have been part of the same issue. I can resolve those as well! Apologies on that one. I can do that within the next hour.

Should I cancel my PR and then add those items in and create a new PR?

No need to cancel fella, just add to this one - they're all part of the same ticket. :)

jonathanprozzi commented 3 years ago

@luxumbra made the changes! My apologies for missing that initially.

I wasn't sure it should be called Minimum Viable Stack since that wasn't the name of the linked article, so I made the link text for the Minimum Viable Stack say MetaSys article since that was the title of the linked page. Definitely can change to a different title if we need!

Thanks

jonathanprozzi commented 3 years ago

Will add those 2 items later tonight -- thanks for the review & feedback!

jonathanprozzi commented 3 years ago

Added those in!

I see there's a reference to MyMeta Profiles . I'm looking for a link to include for this as well since it's referenced. Does this article exist?

image

luxumbra commented 3 years ago

I see there's a reference to MyMeta Profiles . I'm looking for a link to include for this as well since it's referenced. Does this article exist?

image

I am not sure which post this refers to. @peth-yursick do you know of which post this is on about?

luxumbra commented 3 years ago

@peth-yursick do you know which MyMeta profiles post is being referred to here?

luxumbra commented 3 years ago

Added those in!

I see there's a reference to MyMeta Profiles . I'm looking for a link to include for this as well since it's referenced. Does this article exist?

I believe it is this post @jonathanprozzi - https://forum.metagame.wtf/t/mymeta/218 Apologies for the delay getting the info to you.