MetaLabs-inc / react-native-vimeo-iframe

MIT License
44 stars 36 forks source link

App crashes when the react-native-vimeo-iframe leave the viewport #59

Open husnaintahir opened 1 year ago

husnaintahir commented 1 year ago

I have this strange problem on android, i-e if I have a scroller in place and when I try to scroll to the react-native-vimeo-iframe and go more below until react-native-vimeo-iframe is out of view port, the app crashes.

PS: It's working fine on iOS.

Marcoo09 commented 1 year ago

Hi @husnaintahir, are you wrapping the Vimeo component in a ScrollView? If yes, could you try by putting overScrollMode='never' as explained here?

alan-la-chen-478 commented 1 year ago

Still happens to me when adding overScrollMode, but adding another prop works for me. According to this source: https://github.com/meliorence/react-native-render-html/issues/605#issuecomment-1363638140

I have <Vimeo height={height} videoId={id} overScrollMode="never" androidLayerType="software" />

tried both software and hardward, both works and app no crash. not sure what the difference is, but if it works, then i'm good with either.