Preventing common errors, and guiding users to help recover from incomplete actions

omnat commented 5 years ago

Details of problems identified and possible actions here: https://docs.google.com/document/d/1fxPRPePfcDJ-5Db9lxccpu0AqsAXEp9fcBSWH90SKp4/edit Related to Blocknative suggestions in their audit as well.

Alert users when they are trying to submit a duplicate txs
Notify users pro-actively when for transactions are dropped / unapproved / pending for long. To notify users that the tx they wanted to send couldn’t be sent, so try again with higher tx fee / speedup . or cancel, etc.
Guide users to get funds when insufficient funds error (talked about this to @rachel.cope just today)

omnat commented 5 years ago

Blocknative, Rimble have done some pre-work on this. Check out their work to begin with
These might overlap with #139

bdresser commented 5 years ago

@bdresser to come up with (a) categories of error (b) a list of flows where these errors could be useful

omnat commented 5 years ago

Sprint 21: Discuss this one at the retreat

omnat commented 5 years ago

Sprint Sept 30 @bdresser I totally forgot to talk about this at retreat. Where's this at? Should we plan it for this week, or keep for post devcon sprint? We aren't planning this for now, maybe this makes to sprint work at the end of week design sync (thursday)

bdresser commented 4 years ago

happy to have a chat about it later this week but realistically we probably won't get to it until after devcon, right?

omnat commented 4 years ago

(from design sync) Background reading / reference to past chats here: https://github.com/MetaMask/metamask-mobile/issues/341

bdresser commented 4 years ago

Summary

This project is about creating two re-usable components

One screen for "error prevention" that we can use throughout the app as a "warning" screen.
One screen for "error recovery" that we can use throughout the app as an "oops, something went wrong!" screen

Each case will probably have a different "suggested action" and will certainly have different copy, so leaving some flexibility in the CTA buttons & copy space is a good idea. (I've added some examples of what those CTAs could be.

Other considerations

do we want to allow for a "don't show this message again" checkbox ?
are there other flows / common hiccups that we should include in these lists
is one screen sufficient for each, or is there a gentler or more explanatory flow that we should use to help mitigate errors like these?
this will ship to extension first, but could easily add to mobile shortly
some backstory & first principles from @omnat here: https://github.com/MetaMask/Design/issues/125

Error prevention

Retrying duplicate transaction (https://github.com/MetaMask/metamask-extension/issues/4185)
- Primary button speed up or cancel existing tx Secondary Proceed anyway
User is submitting transaction, but several are already pending (https://github.com/MetaMask/metamask-extension/issues/5126)
- Could prompt user to speed up or cancel
- Primary button speed up or cancel existing tx Secondary Proceed anyway
Submitting a tx with gas unnecessarily high
- Primary button Adjust gas Secondary Proceed anyway
Submitting a tx to a token/contract address
- - Primary button Edit recipient Secondary Proceed anyway

Error recovery

Transaction has been pending for a long time (https://github.com/MetaMask/metamask-extension/issues/5738)
- Should prompt user to speed up or cancel
- Could also be making these buttons more apparent passively
Transaction failed on-chain
User tries to Send but has no ETH

bdresser commented 4 years ago

Relates to https://github.com/MetaMask/metamask-extension/issues/5211

omnat commented 4 years ago

@rachelcope to add links to the latest here. Next steps in Sprint 23:

go through the rest of the use-cases,
revisit copy for errors
address questions from design sync

omnat commented 4 years ago

Dev hand-off planned for Nov 13

MetaMask / Design