search

MetaMask / Design

All things design related
7 stars 4 forks source link

New decrypt message UI #149

Open logvik opened 5 years ago

logvik commented 5 years ago

Screenshot for https://github.com/MetaMask/metamask-extension/issues/1190#issuecomment-543091839 decrypt_request

danfinlay commented 5 years ago

Some experience questions:

I'm not sure showing the encrypted blob is useful! It's nearly useless by definition! Maybe parsing out that metadata a bit, to name the type of encryption, and the length of the message, but otherwise it just makes for a more confusing message.

Once we deploy the Login permissions branch we could extend this to a blanket permission, like "Allow domain X to decrypt messages intended for account Y".

danfinlay commented 5 years ago

Rather than showing the encrypted blob, we could even have a "peek at decrypted value" button, so the user could view the decrypted message right there.

The button is more specifically about giving that data back to the site, so I'm trying to think of a good button name for that. Maybe "Approve" is fine if the initial prompt is worded well enough.

logvik commented 5 years ago

If the user approves this, the decrypted result is passed back to the requesting site? If so, we should indicate at the top "The domain X wants to decrypt a message intended for account Y"

Yes, the same as for the signing message process. But here we can add this "Note".

so the user could view the decrypted message right there.

Agreed, then need to add an additional step -> decrypt the message -> share with the website. Maybe for some cases will be preferably taking a look at the message right in the extension and don't share the source text.

logvik commented 5 years ago

For encryption_public_key method we can use the same window with changes:

Title: Encryption public key request

Content: This action will allow using the generated public key for encryption messages in Dapp. This key will be generated via your private key, but can't be used on Ethereum blockchain.

Buttons: Cancel / Generate

logvik commented 5 years ago

@danfinlay sorry for disturbing, but maybe you will have some a little time to review updates in PR in all subprojects?

danfinlay commented 5 years ago

Sorry I'm so behind on emails. There are updates? Want to list out the links here for my convenience so I can knock them out quickly?

logvik commented 5 years ago

all updates are attached to https://github.com/MetaMask/metamask-extension/issues/1190

danfinlay commented 4 years ago

I've merged the non-design related PRs. Just waiting on design & UI finalization to merge #7247.