feat!: create new vault with any keyring

[gantunesr]

Description

This change updates the logic inside the eth-keyring-controller to allow the creation of a vault with any keyring. This removes the hardcoded HD Keyring from the code and allow the client to pass the parameters to instantiate any keyring that is accepted by the controller.

Changes

• BREAKING: Unify createNewVaultAndKeychain and createNewVaultAndRestore into new method createNewVaultWithKeyring. createNewVaultWithKeyring accepts a password and a keyring object provided by the client and returns the KeyringControllerState

References

No references

Checklist

• [x] I've updated the test suite for new or updated code as appropriate
• [x] I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
• [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

[legobeat]

@gantunesr Do you think we can get in #314 and release #304 prior to merging this? Seems desirable to sync the branches and get the fixes out separately from this breaking feature?

[gantunesr]

@mikesposito Yes! I'll have this done in @metamask/keyring-controller too