search

MetaMask / action-npm-publish

GitHub Action to publish to NPM
MIT License
8 stars 6 forks source link

Disallow publishing packages with version 0.0.0 #57

Closed mcmire closed 7 months ago

mcmire commented 1 year ago

Sometimes when adding a new package to a monorepo, the version will be set to 0.0.0 and then this "dummy" version will be accidentally published. In that case, we don't want to publish the version.

This case was already handled on the action-publish-release side here. In a repo that uses that action in addition to this one (which is the case for all MetaMask repos), 0.0.0 should never be published, since that action is run before this one. However, this problem is still worth solving in case people are using this action separate from action-publish-release.

Gudahtt commented 8 months ago

I think this is still a problem for monorepos, even with the validation in action-publish-release. We've noticed 0.0.0 versions published in the core repo lately for example

desi commented 7 months ago

Blocked by CI issue in the repository.