Disallow publishing packages with version 0.0.0

MetaMask / action-npm-publish

GitHub Action to publish to NPM

MIT License

8 stars 6 forks source link

Disallow publishing packages with version 0.0.0 #61

Closed rickycodes closed 7 months ago

rickycodes commented 8 months ago

closes #57

Gudahtt commented 7 months ago

It looks like CI checks aren't being run here because the repository's workflow only runs on push, not on pull_request events. We should be able to update that workflow to run on pull_request as well.

mcmire commented 7 months ago

@Gudahtt Added here: https://github.com/MetaMask/action-npm-publish/pull/62

Gudahtt commented 7 months ago

Closed in favor of #63 because the shellcheck step doesn't support forks (it silently fails when the GITHUB_TOKEN passed in only has read access to checks)