MetaMask / action-publish-release

MIT License
13 stars 6 forks source link

List package versions in releases for monorepos with independent versioning #79

Closed mcmire closed 1 year ago

mcmire commented 1 year ago

Currently, the notes for a independently-versioned monorepo release lists all of the packages that are included in that release, but does not list the versions of those packages that are being published. This makes reviewing past releases difficult as we have to cross-reference package tags with monorepo tags to determine those versions.

This commit fixes that. For instance, instead of seeing the following for a GitHub release:

59.0.0

@metamask/base-controller

(release notes for base-controller)

@metamask/controller-utils

(release notes for controller-utils)

we should now see:

59.0.0

@metamask/base-controller 4.0.0

(release notes for base-controller)

@metamask/controller-utils 5.0.0

(release notes for controller-utils)

mcmire commented 1 year ago

@Mrtenz Yeah, that makes more sense. Updated in 337e18f.

Gudahtt commented 1 year ago

Looks great! CI still failing though

mcmire commented 1 year ago

I've fixed CI on this PR: https://github.com/MetaMask/action-publish-release/pull/80

mcmire commented 1 year ago

I've tested this on a monorepo with independent versions (core), a monorepo with fixed versions (snaps), and a polyrepo (utils), and all of them seemed to work as designed. Here are the resulting GitHub releases: