MetaMask / auto-changelog

Utilities for validating and updating "Keep a Changelog" formatted changelogs
Apache License 2.0
6 stars 10 forks source link

fix: move @metamask/utils from devDeps to deps #168

Closed legobeat closed 11 months ago

legobeat commented 11 months ago

https://github.com/MetaMask/utils/actions/runs/6601251324/job/17932102826?pr=152

node:internal/modules/cjs/loader:1051
  throw err;
  ^

Error: Cannot find module '@metamask/utils'
Require stack:
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/init.js
- /home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/cli.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js:18:17)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/changelog.js',
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/init.js',
    '/home/runner/work/utils/utils/node_modules/@metamask/auto-changelog/dist/cli.js'
  ]
}
mcmire commented 11 months ago

@legobeat ~Hmm... this doesn't seem right. This isn't a development dependency; it legitimately is used in this package. So wouldn't this break normal usage of this package on the command line? For instance, if you were to just call this via yarn dlx @metamask/auto-changelog or npx @metamask/auto-changelog, it wouldn't work.~

Wow, I misread this PR title. Apologies. This is definitely right, not sure how we missed this before.