MetaMask / contract-metadata

A mapping of ethereum contract addresses to broadly accepted icons for those addresses.
ISC License
455 stars 1.11k forks source link

Add support for BAG token #1346

Closed Garchbold closed 1 month ago

MRabenda commented 2 months ago

Hey, before We would be able to merge it - I would like to improve icon quality:

  1. Your image currently has some significant padding - do you want to have it?
  2. Regular SVG logo like yours should be <15kB - current one is over 150kB, would you be able to work on better SVG image?
Garchbold commented 2 months ago

@MRabenda thanks for the followup, we were able to get it down ~25kb, is that sufficient. This is the smallest we could get it while keeping the colors intact.

MRabenda commented 2 months ago

Hey, sorry @Garchbold but in the code of the image we can find

</clipPath> <image id="image0_1387_4858" width="375" height="375" xlink:href="data:image/png;base64,iVBORw0KGgoAA....

This is actually still PNG raster image instead of SVG vector one

Garchbold commented 1 month ago

Hey @MRabenda just checking in again is there still an outstanding issue for this pr?

MRabenda commented 1 month ago

I would be able to merge it with proper vector image, not a PNG saved as SVG

Garchbold commented 1 month ago

is 70 kB sufficient, after switching it to a proper vector image thats the size that we end up at

MRabenda commented 1 month ago

If is a full vector that should be fine, please update it

Garchbold commented 1 month ago

Hey @MRabenda just updated, please let me know if that works, thank you

MRabenda commented 1 month ago

Hey,

Icon looks good - last missing element is that address should be in EIP-55 format - the correct one would look like 0x808688c820AB080A6Ff1019F03E5EC227D9b522B

Garchbold commented 1 month ago

Thanks for all the patience @MRabenda it should be ready now

b4u5 commented 1 month ago

when could we expect this to be reflected in prod?

Garchbold commented 1 month ago

Hey @MRabenda

We are still seeing the incorrect image in metamask on polygon, is there a another repo we need to fork for the image to show up there?

Screenshot 2024-10-08 at 11 18 52 AM Screenshot 2024-10-08 at 11 20 23 AM

sahar-fehri commented 1 month ago

Hello @Garchbold 👋 Could you check now if the contract on polygon 0x73b29199a8e4c146e893eb95f18dac41738a88c6 has the right icon?