search

MetaMask / contract-metadata

A mapping of ethereum contract addresses to broadly accepted icons for those addresses.
ISC License
448 stars 1.1k forks source link

add token logo Africash #1353

Closed mantogo closed 2 weeks ago

mantogo commented 3 weeks ago

add token logo Africash

MRabenda commented 3 weeks ago
  1. On which chain this token is deployed?
  2. Can you remove png file from the PR?
  3. Can you please fix json file to do not remove existing assets?
mantogo commented 3 weeks ago

hello.

The token is deployed on Binance smart chain.

I have tried to submit a new pr because i was not getting reply that is why. sorry for the duplication.

unfortunately I can't remove the png file. only the svg file is deletable on my page.

how can i fix json file to not remove existing assets. i don't get it

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: MRabenda @.> Sent: Wednesday, August 28, 2024 11:14:08 AM To: MetaMask/contract-metadata @.> Cc: mantogo @.>; Author @.> Subject: Re: [MetaMask/contract-metadata] add token logo Africash (PR #1353)

  1. On which chain this token is deployed?
  2. Can you remove png file from the PR?
  3. Can you please fix json file to do not remove existing assets?

— Reply to this email directly, view it on GitHubhttps://github.com/MetaMask/contract-metadata/pull/1353#issuecomment-2314499372, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXB3HVNOXTMTHMTBTBAWCHLZTV2EBAVCNFSM6AAAAABNGZZPICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUGQ4TSMZXGI. You are receiving this because you authored the thread.Message ID: @.***>

mantogo commented 2 weeks ago

hello

please is there anything else i can do?

mantogo commented 2 weeks ago

hello

please is there anything else i can do?

should I close the pr please and start a new one?

MRabenda commented 2 weeks ago

You have to fix PR - you can do this in a current one, or open new one if you prefer

mantogo commented 2 weeks ago

ok im going to open a new one witch will include svg logo now

mantogo commented 2 weeks ago

done. new one created

mantogo commented 2 weeks ago

close