search

MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
288 stars 184 forks source link

Introduce concept of `PermissionGroups` to the `PermissionController` #1459

Open hmalik88 opened 1 year ago

hmalik88 commented 1 year ago

As it stands, we currently have a 1 to 1 mapping from permission to rpc method. With the addition of multiple rpc methods that fall around the same action or permission, it is necessary for the PermissionController to be able to process a permission request for a parent permission and subsequently install the child permissions. This greatly reduces the visual overload you get from seeing multiple related permissions in the connect screen.

The first permission to have a group would be snap_manageState and then eventually the forthcoming custom ui rpc methods.

Spec in Notion: https://www.notion.so/Permission-Groups-7a4047730e8745c2ac17d7714f791dcc

kenhkan commented 1 year ago

From sprint planning: Pending review of the doc Hassan just shared

kenhkan commented 12 months ago

From 1:1 with Hassan: We need to re-point this after meeting this Friday.

kenhkan commented 11 months ago

From 1:1 with Hassan: We are leaving this in the backlog to work on something more pressing.

rekmarks commented 5 months ago

We are very likely going to move away from the 1:1 representation of method:permission beginning with the multichain provider API. I will probably close this issue once we have an issue up for that work.