Ensure that all controllers used across clients are using BaseControllerV2

[mcmire]

These controllers are still using BaseController (v1) and need to be migrated to BaseControllerV2. Some controllers don't need to be controllers at all.

Core packages

• [ ] Message managers (perhaps these need to be called "*Controller"?) (https://github.com/MetaMask/MetaMask-planning/issues/1930 — Confirmations team handling)
  • AbstractMessageManager
  • PersonalMessageManager
  • DecryptMessageManager
  • EncryptionPublicKeyManager
  • MessageManager
  • PersonalMessageManager
  • TypedMessageManager
• [x] AddressBookController (#4070)
• [x] AccountTrackerController (#4071)
• [x] AnnouncementController (https://github.com/MetaMask/core/pull/959)
• [x] ApprovalController (https://github.com/MetaMask/core/pull/555)
• [x] AssetsContractController (#4072)
• [x] KeyringController (https://github.com/MetaMask/core/pull/1378)
• [x] NetworkController (https://github.com/MetaMask/core/pull/903)
• [x] NftController (#4073)
• [x] NftDetectionController (#4074)
• [x] TokenBalancesController (#1808)
• [x] TokenDetectionController (#3625)
• [x] TokenRatesController (#4076)
• [x] TokensController (#4075)
• [x] ComposableController (#2082)
• [x] PhishingController (#1705)
• [x] PreferencesController (#3708)
• [x] TransactionController (#3758)

Non-core packages

• [ ] MetaMask/smart-transactions-controller
• [ ] MetaMask/swaps-controller

Extension controllers

• [ ] AccountTrackerController (https://github.com/MetaMask/metamask-extension/issues/25928, https://github.com/MetaMask/metamask-extension/issues/25929)
• [ ] AlertController (https://github.com/MetaMask/metamask-extension/issues/25921, https://github.com/MetaMask/metamask-extension/issues/25915)
• [ ] AppStateController (https://github.com/MetaMask/metamask-extension/issues/25922, https://github.com/MetaMask/metamask-extension/issues/25916)
• [ ] MetaMetricsController (https://github.com/MetaMask/metamask-extension/issues/25924, https://github.com/MetaMask/metamask-extension/issues/25925)
• [ ] MMIController (https://github.com/MetaMask/metamask-extension/issues/25926)
• [x] OnboardingController (https://github.com/MetaMask/metamask-extension/issues/25927)
• [x] PreferencesController (https://github.com/MetaMask/metamask-extension/issues/25923, https://github.com/MetaMask/metamask-extension/issues/25917)
• [x] SwapsController (https://github.com/MetaMask/metamask-extension/pull/25681)

[MajorLift]

These also need to be updated:

• external:
  • [ ] SmartTransactionsController
  • [ ] SwapsController

Completed:

• core:
  • [x] AnnouncementController: https://github.com/MetaMask/core/pull/959
  • [x] ApprovalController: https://github.com/MetaMask/core/pull/555
  • [x] KeyringController: https://github.com/MetaMask/core/pull/1378
  • [x] NetworkController: https://github.com/MetaMask/core/pull/903
  • [x] PhishingController: https://github.com/MetaMask/core/pull/1705

[MajorLift]

@desi @mcmire Could we convert this into an epic? I think it would be helpful keep track of our progress on these upgrades, especially since some of them are prerequisites for work currently being done on controllers by us (https://github.com/MetaMask/core/issues/1780) and DevEx, Confirmations etc.

[mcmire]

@MajorLift Done!