Open rekmarks opened 3 months ago
Comment thread where two more people experienced this: https://github.com/MetaMask/core/pull/4506#discussion_r1673148521
In my case, it was something about my local dev environment that was off. Unfortunately, I didn't document the fix that ended up working, and haven't been able to repro the bug.
It wasn't a complex fix. It might have been removing node_modules
and reinstalling dependencies, removing eslint cache, or something of the sort.
I did several variations of the following to no effect:
# in ./core
# I don't know that there's more than one of these, but it's best to be sure
find . -type f -name ".eslintcache" -exec rm {} +
rm -rf node_modules
yarn cache clean
ESLint succeeds in fresh clone of the repo, but only in a different directory on my system. If I delete my original copy of the repo and replace it with the freshly cloned copy, it starts failing again. There are no .eslintconfig
files in any parent directory, and the Node versions are the same. This is definitely local to my system, but I don't understand the hell that I'm in.
I'll leave this open for other people who are debugging their local ESLint behavior.
I've just run into this problem again. There are two lint issues I see locally. I have tried all of the solutions posted above to remove them without success. I've attempted to fix these here but we shouldn't have to do this: https://github.com/MetaMask/core/pull/4545
Still running into this problem as of October 2024 — this time it's the @typescript-eslint/restrict-template-expression
that's failing locally for me (but obviously not failing in CI, otherwise CI would be failing on main
). This ESLint rule has failed numerous times in the past for me and is rather unreliable, so it's not a surprise, but still, rather annoying.
Recently, @mcmire put up #4537 to address some lint errors he observes locally (ref: https://github.com/MetaMask/core/pull/4537#issuecomment-2237108995). These began to appear on his system after my PR #4521. I am unable to observe the same errors. On the other hand, I observe no less than 44 errors from the root
yarn lint
on current main (b7fa70e1):ESLint output