MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
293 stars 188 forks source link

ci: "create-update-issues" workflow skips pre-1.0 breaking changes #4904

Open Gudahtt opened 2 weeks ago

Gudahtt commented 2 weeks ago

The create-update-issues workflow is intended to create issues in extension and mobile for updating controllers after a breaking change. However, it currently only looks for major version bumps. Breaking changes to controllers that are pre-1.0 are not considered.

We should update the workflow to create issues for breaking changes in pre-1.0 controllers as well. i.e. when the major version is zero, a minor bump should be considered breaking and trigger the creation of issues.

Note that technically according to SemVer, any pre-1.0 release can be breaking, even patch releases. But it's conventional for many package authors (and on our team) that pre-1.0 breaking changes be released as a minor version bump (and this is how the ^ operator works, see here for more details), so that's what this workflow will assume.