Open Prithpal-Sooriya opened 1 week ago
Hello! I have some concerns here and would definitely love to understand the use case for the new method you're adding. As you've mentioned elsewhere, there is a lot going on already in the network controller and I just want to make sure that we absolutely need a different way of updating a network configuration.
@mcmire yep I agree, this is a very big change. As mentioned in the PR description, I'm planning on having a 1:1 with the assets team and also include a code walkthrough.
Happy to include you and discuss in DMs the context for this change.
@Prithpal-Sooriya That would be great, thanks!
@Gudahtt yep sure, will add an ADR.
I'm not planning on merging this work until we get team-wide acceptance.
Explanation
A set of changes to support network syncing. This is a big scary change, so will have a 1:1 with assets team and pair review this.
I'll also record a loom vid for a quick code walkthrough.
References
N/A
Changelog
@metamask/network-controller
networkClientId
if provided instead ofuuidV4()
dangerouslySetNetworkConfiguration
to cautiously overwrite a given network configuration. Used for network syncing, where we need to override local state with the synced remote state.Checklist