MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
293 stars 188 forks source link

chore: Remove `useRequestQueue` toggle to turn on/off Per Dapp Selected Network Feature #4941

Closed adonesky1 closed 4 days ago

adonesky1 commented 1 week ago

Explanation

The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago.

Screenshot 2024-11-19 at 10 58 04 AM

This PR removes the togglability of per dapp selected network from the SelectedNetworkController and QueuedRequestMiddleware

The extension to integrate this change will also have to implement a migration to remove this state.

Another reason we should remove this now is that having this setting turned off is causing a bug to result with wallet_switchEthereumChain and the interaction between the new chain permissions feature and the absence of queuing.

References

Extension PR w/ preview builds of this PR (plus full removal of the toggle): https://github.com/MetaMask/metamask-extension/pull/28577

When integrated in the extension will resolve this issue: https://github.com/MetaMask/metamask-extension/issues/28441

Changelog

@metamask/queued-request-controller

@metamask/selected-network-controller

Checklist

adonesky1 commented 1 week ago

@metamaskbot publish-preview

github-actions[bot] commented 1 week ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. ``` { "@metamask-previews/accounts-controller": "19.0.0-preview-fc955bd0", "@metamask-previews/address-book-controller": "6.0.1-preview-fc955bd0", "@metamask-previews/announcement-controller": "7.0.1-preview-fc955bd0", "@metamask-previews/approval-controller": "7.1.1-preview-fc955bd0", "@metamask-previews/assets-controllers": "44.0.0-preview-fc955bd0", "@metamask-previews/base-controller": "7.0.2-preview-fc955bd0", "@metamask-previews/build-utils": "3.0.1-preview-fc955bd0", "@metamask-previews/chain-controller": "0.1.3-preview-fc955bd0", "@metamask-previews/composable-controller": "9.0.1-preview-fc955bd0", "@metamask-previews/controller-utils": "11.4.3-preview-fc955bd0", "@metamask-previews/ens-controller": "15.0.0-preview-fc955bd0", "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-fc955bd0", "@metamask-previews/gas-fee-controller": "22.0.1-preview-fc955bd0", "@metamask-previews/json-rpc-engine": "10.0.1-preview-fc955bd0", "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-fc955bd0", "@metamask-previews/keyring-controller": "18.0.0-preview-fc955bd0", "@metamask-previews/logging-controller": "6.0.2-preview-fc955bd0", "@metamask-previews/message-manager": "11.0.1-preview-fc955bd0", "@metamask-previews/multichain": "0.0.0-preview-fc955bd0", "@metamask-previews/name-controller": "8.0.1-preview-fc955bd0", "@metamask-previews/network-controller": "22.0.2-preview-fc955bd0", "@metamask-previews/notification-controller": "7.0.0-preview-fc955bd0", "@metamask-previews/notification-services-controller": "0.13.0-preview-fc955bd0", "@metamask-previews/permission-controller": "11.0.3-preview-fc955bd0", "@metamask-previews/permission-log-controller": "3.0.1-preview-fc955bd0", "@metamask-previews/phishing-controller": "12.3.0-preview-fc955bd0", "@metamask-previews/polling-controller": "12.0.1-preview-fc955bd0", "@metamask-previews/preferences-controller": "14.0.0-preview-fc955bd0", "@metamask-previews/profile-sync-controller": "1.0.0-preview-fc955bd0", "@metamask-previews/queued-request-controller": "7.0.1-preview-fc955bd0", "@metamask-previews/rate-limit-controller": "6.0.1-preview-fc955bd0", "@metamask-previews/selected-network-controller": "19.0.0-preview-fc955bd0", "@metamask-previews/signature-controller": "22.0.0-preview-fc955bd0", "@metamask-previews/transaction-controller": "39.0.0-preview-fc955bd0", "@metamask-previews/user-operation-controller": "18.0.0-preview-fc955bd0" } ```