The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago.
This PR removes the togglability of per dapp selected network from the SelectedNetworkController and QueuedRequestMiddleware
The extension to integrate this change will also have to implement a migration to remove this state.
Another reason we should remove this now is that having this setting turned off is causing a bug to result with wallet_switchEthereumChain and the interaction between the new chain permissions feature and the absence of queuing.
Explanation
The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago.
This PR removes the togglability of per dapp selected network from the
SelectedNetworkController
andQueuedRequestMiddleware
The extension to integrate this change will also have to implement a migration to remove this state.
Another reason we should remove this now is that having this setting turned off is causing a bug to result with
wallet_switchEthereumChain
and the interaction between the new chain permissions feature and the absence of queuing.References
Extension PR w/ preview builds of this PR (plus full removal of the toggle): https://github.com/MetaMask/metamask-extension/pull/28577
When integrated in the extension will resolve this issue: https://github.com/MetaMask/metamask-extension/issues/28441
Changelog
@metamask/queued-request-controller
createQueuedRequestMiddleware
no longer expects auseRequestQueue
property in its param options.@metamask/selected-network-controller
useRequestQueuePreference
oronPreferencesStateChange
paramsChecklist