search

MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
287 stars 186 forks source link

Fallback to getting collectible contract information from the contract itself. #686

Open fmdev99 opened 2 years ago

fmdev99 commented 2 years ago

Currently the controller is getting collectible contract name and symbol information from the contract itself, but all other information is retrieved from OpenSea. As a fallback, metamask could pull information directly from the contract if OpenSea doesn't have the data. This could use the OpenSea standard here for "contractURI": https://docs.opensea.io/docs/contract-level-metadata

A big motivation for this is currently only projects on the 3 chains supported by OpenSea can have icons for their NFT collections in metamask mobile. This would provide a mechanism for projects that aren't on a chain support by OpenSea to specify an image icon for their NFT collections.

mcmire commented 2 years ago

@adonesky1 Can you answer this one? I feel like the changes you've made recently could possibly address this.

adonesky1 commented 2 years ago

This would involve us endorsing the addition of a new method not included in either the ERC721 or ERC1155 contract standard, one that OpenSea has unilaterally defined. I'm not against this method per se but I think we should discuss before defaulting into adoption of this new standard proposed by OpenSea. In any case this would only apply to contracts that have already adopted this standard recommended to them by OpenSea or any contracts that elect to do so in the future. cc @mcmire @FrederikBolding @rekmarks

fmdev99 commented 1 year ago

This would involve us endorsing the addition of a new method not included in either the ERC721 or ERC1155 contract standard, one that OpenSea has unilaterally defined. I'm not against this method per se but I think we should discuss before defaulting into adoption of this new standard proposed by OpenSea. In any case this would only apply to contracts that have already adopted this standard recommended to them by OpenSea or any contracts that elect to do so in the future. cc @mcmire @FrederikBolding @rekmarks

But the current method is literally only pulling information from OpenSea. So, you already only support information unilaterally defined by OpenSea. By supporting this standard, you at least open the option of other chains working which OpenSea doesn't support.