search

MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
290 stars 187 forks source link

expose KeyringControler.verifyPassword #870

Open owencraston opened 2 years ago

owencraston commented 2 years ago

Currently we are validating passwords by calling await KeyringController.submitPassword(credentials.password) which is a heavy operation and is dramatically slowing down the UI. I see that base KeyringController has a verifyPassword method that is not exposed by this wrapper. We could expose this method so we can check passwords without running a full update.

desi commented 6 months ago

We do now expose verifyPassword but not in the recommended way. We should also update on mobile.

desi commented 6 months ago

Potential blocker for Wallet Frame - Desi add to release (once I create).

Remaining work is to add action.