MetaMask / design-tokens

Design tokens to be used throughout MetaMask products
https://metamask.github.io/design-tokens/?path=/docs/getting-started-introduction--docs
27 stars 15 forks source link

Enhancements to CircleCI Script and Storybook Build #583

Closed georgewrmarshall closed 7 months ago

georgewrmarshall commented 7 months ago

Description

This Pull Request introduces several updates aimed at improving our CircleCI script and the discoverability of the Storybook build within the MetaMask bot comment. The script has been modified, it still builds a version of Storybook that includes the changes proposed in the current PR. However, instances referencing specific branches (e.g., develop) within the extension code base have been removed as well as the script to list all the changes to different files as it does not work as expected even in extension. This change reduces dependencies and potential confusion caused by branch-specific references. Enhancements have also been made to make the Storybook build more discoverable within the MetaMask bot comment. This improvement aims to streamline the review process by making it easier to locate and access the Storybook build.

Initially this PR was supposed to fix the failing build but was resolved by @Gudahtt

Fixes: https://github.com/MetaMask/design-tokens/issues/584

Screenshot/Screencasts

Before

https://github.com/MetaMask/design-tokens/assets/8112138/6d6bb560-70f3-42dd-a1a5-1886bb8f16f1

After

https://github.com/MetaMask/design-tokens/assets/8112138/f18af389-969c-4bac-8bae-dfc8fe91423f

Manual testing steps

  1. Got to a previously merged PR
  2. Find the metamaskbot comment https://github.com/MetaMask/design-tokens/pull/486#issuecomment-1592430954
  3. See storybook build hidden under dropdown
  4. On this PR scroll down to the metamaskbot comment
  5. See storybook link clearly exposed for review https://github.com/MetaMask/design-tokens/pull/583#issuecomment-1896759473
metamaskbot commented 7 months ago

Builds ready [4b56da5]

Storybook: Storybook

garrettbear commented 7 months ago

LGTM