socket-security[bot]
commented
7 months ago New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/core@7.23.5, npm/@babel/generator@7.23.5, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-create-class-features-plugin@7.23.5, npm/@babel/parser@7.23.5, npm/@babel/preset-env@7.23.5, npm/@babel/runtime@7.23.5, npm/@babel/template@7.22.15, npm/@babel/traverse@7.23.5, npm/@babel/types@7.23.5, npm/@jridgewell/gen-mapping@0.3.2, npm/@jridgewell/trace-mapping@0.3.20, npm/@lavamoat/allow-scripts@1.0.6, npm/@metamask/eslint-config-jest@9.0.0, npm/@metamask/eslint-config-nodejs@9.0.0, npm/@metamask/eslint-config-typescript@9.0.1, npm/@metamask/eslint-config@9.0.0, npm/@storybook/addon-a11y@7.6.10, npm/@storybook/addon-actions@7.6.10, npm/@storybook/addon-essentials@7.6.10, npm/@storybook/addon-links@7.6.10, npm/@storybook/addon-mdx-gfm@7.6.10, npm/@storybook/react-webpack5@7.6.10, npm/@storybook/react@7.6.10, npm/@types/babel__traverse@7.20.4, npm/@types/istanbul-lib-coverage@2.0.4, npm/@types/jest@26.0.24, npm/@types/node@18.19.3, npm/@types/qs@6.9.10, npm/@typescript-eslint/eslint-plugin@4.33.0, npm/@typescript-eslint/experimental-utils@4.33.0, npm/@typescript-eslint/parser@4.33.0, npm/abab@2.0.6, npm/anymatch@3.1.2, npm/assert-plus@1.0.0, npm/babel-loader@8.2.5, npm/browserslist@4.22.2, npm/core-js-compat@3.34.0, npm/es-abstract@1.20.1, npm/eslint-config-prettier@8.5.0, npm/eslint-plugin-jest@24.7.0, npm/eslint-plugin-jsdoc@36.1.1, npm/eslint-plugin-prettier@3.4.1, npm/eslint@7.32.0, npm/espree@7.3.1, npm/extend-shallow@3.0.2, npm/extsprintf@1.3.0, npm/fast-glob@3.2.11, npm/get-value@2.0.6, npm/ignore@5.2.0, npm/is-descriptor@1.0.2, npm/is-extendable@0.1.1, npm/is-typedarray@1.0.0, npm/istanbul-lib-coverage@3.2.0, npm/jest-diff@26.6.2, npm/jest@26.6.3, npm/minimist@1.2.6, npm/object-inspect@1.12.2, npm/postcss-modules-local-by-default@4.0.3, npm/postcss-selector-parser@6.0.10, npm/postcss@8.4.32, npm/prettier-plugin-packagejson@2.2.18, npm/pretty-format@26.6.2, npm/psl@1.9.0, npm/punycode@2.1.1, npm/regex-not@1.0.2, npm/sass@1.54.3, npm/set-value@2.0.1, npm/split-string@3.1.0, npm/storybook@7.6.10, npm/terser-webpack-plugin@5.3.9, npm/terser@5.26.0, npm/to-regex@3.0.2, npm/ts-jest@26.5.6, npm/tsconfig-paths@3.14.1, npm/tweetnacl@0.14.5, npm/typescript@4.7.4, npm/whatwg-url@8.7.0, npm/which-typed-array@1.1.13
metamaskbot
georgewrmarshall
Description
This PR aims to update the design token package, which was originally generated from the metamask-module-template. Over time, the package has become outdated and incompatible with mobile and portfolio due to dependency issues, particularly with node versions. This PR addresses these issues by updating the dependencies and aligning the package with the most recent module template using the template sync package.
The upgrade to yarn version 3 also necessitated changes to the GitHub workflow files, which were updated to align with the module template. This alignment should enhance the automation of our releases. Due to the upgraded node and yarn versions, this PR includes numerous other dependency updates, file changes, lint fixes, and the inclusion of config files.
Fixes: #597
Manual Testing Steps
Because mobile and portfolio are using yarn v1 and the design tokens is using v3. It's quite hard to test using yarn link. But if you pull this branch and try to use yarn link on a project that use yarn 3 it will work like the module template.
yarn && yarn buildyarn link ../path/to/design-tokensbrandColorin to theindex.tsfileOther smoke tests
yarn storybookScreencasts/Screenshots
Screencast below shows yarn link version of the design-tokens to the module-template as a test to ensure that the
brandColorobject in thev1.13release is importing and working as intendedhttps://github.com/MetaMask/design-tokens/assets/8112138/5e5f52c4-3be1-462a-8c02-bbe5f4b5912d