Closed garrettbear closed 2 months ago
PR: https://github.com/MetaMask/metamask-extension/pull/25268 Storybook: https://output.circle-artifacts.com/output/job/73c987ab-ee77-42f1-a5ca-5645595f007c/artifacts/0/storybook/index.html?path=/story/components-componentlibrary-button--variant Build: https://github.com/MetaMask/metamask-extension/pull/25268#issuecomment-2164030149
No errors related to design system
There are a couple instances that use the JS tokens, so they haven't been updated in the test build
Yes I cover that in my video, sorry you beat me before I could get the video loaded @georgewrmarshall
this is using a bypass by using a copy and paste of the CSS file for design tokens, but doesn't cover the JS updates https://github.com/MetaMask/design-tokens/assets/26469696/497a9ae0-e227-4eb2-9291-478b9cd991cd
This video is using yarn link so it includes the JS and CSS (toggle button uses JS)
https://github.com/MetaMask/design-tokens/assets/26469696/7a7d0ca2-f174-414b-94cc-992a4ea3f3f9
There are a couple instances that use the JS tokens, so they haven't been updated in the test build
using yarn link
Excellent videos LGTM!
Look good. I Approve
LGTM
Description
The purpose of this ticket is to ensure that the recent updates to the design tokens, as part of our brand evolution, are correctly implemented and functioning as expected in the portfolio's pre-release branch. This involves a comprehensive testing phase to identify any discrepancies, visual or functional, that may arise from the new design token updates.
Technical Details
feature/brand-evolution-design-tokens
branch.Acceptance Criteria