chore: clean up json

[georgewrmarshall]

Description

This PR focuses on cleaning up the Figma design token JSON file by removing any symbols or descriptors from token names, such as * or textual descriptors like "strong". This ensures a cleaner, more standardized naming convention across our design tokens which in turn will make it easier to automate and transform into JS and CSS.

Related Issues

• Fixes: N/A

Manual Testing Steps

To verify the changes, follow these steps:

1. Navigate to the updated Figma JSON file page.
2. Use the search function to look for previously removed terms (e.g., *, "strong").
3. Confirm that no such terms are present in the token names.

Screenshots/Recordings

Adding visual evidence of the changes can significantly enhance the review process. If applicable, please include screenshots or recordings that showcase the difference made by this PR.

Before

https://github.com/MetaMask/design-tokens/assets/8112138/232adedc-9c98-492d-b2e8-05566e9f2d2a

After

https://github.com/MetaMask/design-tokens/assets/8112138/7ac56aa2-bb30-4ea0-96a9-b3d44e5cc1b5

No remaining instances of *, soft or strong

Pre-merge Author Checklist

• [x] Adherence to MetaMask Coding Standards confirmed.
• [x] The problem and solution are clearly described in the PR.
• [ ] Related issues are linked.
• [x] Manual testing steps are detailed.
• [x] Screenshots/recordings are included if applicable.
• [x] Tests are included if applicable.
• [x] Code is documented using JSDoc format if applicable.
• [x] The correct labels have been applied to the PR.
• [x] PR status is accurately set.

Pre-merge Reviewer Checklist

• [ ] Manual testing of the PR has been conducted.
• [ ] The PR meets all acceptance criteria described in the related issue(s).
• [ ] Testing evidence (e.g., recordings, screenshots) is provided.

[metamaskbot]

Builds ready [03b22d3]

Storybook: Storybook

[metamaskbot]

Builds ready [1226528]

Storybook: Storybook