MetaMask / design-tokens

Design tokens to be used throughout MetaMask products
https://metamask.github.io/design-tokens/?path=/docs/getting-started-introduction--docs
25 stars 15 forks source link

fix: updating brand color figma json #702

Closed georgewrmarshall closed 1 month ago

georgewrmarshall commented 1 month ago

Description

This PR updates the Figma JSON to remove all opacity brand color values and adds white and black colors. The reason for this change is to ensure brand consistency and improve the design system by using solid colors for white and black instead of opacity variations.

Related issues

Fixes: N/A

Manual testing steps

  1. Open the MetaMask extension.
  2. Verify that all brand colors using opacity have been replaced with solid white and black.
  3. Check various UI components to ensure the design is consistent and no visual elements are missing or incorrectly colored.

Screenshots/Recordings

Before and After screenshots are listed in the code comments for easier review

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented 1 month ago

Builds ready [1f06eef]

Storybook: Storybook

garrettbear commented 1 month ago

white and black will likely not work, but they will start working with this PR

metamaskbot commented 1 month ago

Builds ready [cca01a7]

Storybook: Storybook

metamaskbot commented 1 month ago

Builds ready [6b0d1df]

Storybook: Storybook

metamaskbot commented 1 month ago

Builds ready [5dd2eaf]

Storybook: Storybook

metamaskbot commented 1 month ago

Builds ready [b9f285a]

Storybook: Storybook

metamaskbot commented 1 month ago

Builds ready [dbfcd4a]

Storybook: Storybook

metamaskbot commented 1 month ago

Builds ready [07764c9]

Storybook: Storybook

georgewrmarshall commented 1 month ago

can you double check with hiro regarding the icon tokens situation?

I think either work for now. We can change it back to text in a future update once docs updates have been merged it contains the logic to handle those aliases https://github.com/MetaMask/design-tokens/pull/706

metamaskbot commented 1 month ago

Builds ready [47ed81b]

Storybook: Storybook