search

MetaMask / eth-json-rpc-filters

json-rpc-engine middleware implementing ethereum filter methods
ISC License
30 stars 38 forks source link

devDeps: ethjs-query@^0.3.8 -> @metamask/ethjs-query@^0.7.0 #127

Closed legobeat closed 1 year ago

socket-security[bot] commented 1 year ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ethjs-query 0.7.0 None +7 2.19 MB lgbot
@babel/runtime 7.23.2 None +1 275 kB nicolo-ribaudo

🚮 Removed packages: ethjs-query@0.3.8

socket-security[bot] commented 1 year ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Unstable ownership @metamask/ethjs-query 0.7.0

Next steps

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @metamask/ethjs-query@0.7.0
mcmire commented 1 year ago

I don't think we need to do this; I think we can just drop ethjs-query altogether. See: https://github.com/MetaMask/eth-json-rpc-filters/issues/128

legobeat commented 1 year ago

I don't think we need to do this; I think we can just drop ethjs-query altogether. See: #128

Does that mean that ethjs-query compatibility is not actually needed to be preserved or guaranteed for this module?

mcmire commented 1 year ago

@legobeat Yes, exactly.