search

MetaMask / eth-json-rpc-filters

json-rpc-engine middleware implementing ethereum filter methods
ISC License
29 stars 38 forks source link

Why do we pad uneven length hex numbers with leading zeros? #152

Open BelfordZ opened 5 months ago

BelfordZ commented 5 months ago

Can anyone tell me why? https://github.com/MetaMask/eth-json-rpc-filters/blob/main/hexUtils.js#L55

This is causing tests against https://github.com/ethereum/execution-apis to fail (expects hex number that is not zero-leading)

shanejonas commented 4 months ago

geth and the spec no longer support leading 0s

rel https://github.com/ethereum/execution-apis/issues/40#issuecomment-906400324 rel https://github.com/NomicFoundation/hardhat/issues/1585#issuecomment-906638245

shanejonas commented 4 months ago

rel https://github.com/MetaMask/eth-json-rpc-filters/pull/71 rel https://github.com/MetaMask/eth-json-rpc-filters/issues/70