MetaMask / eth-json-rpc-filters

json-rpc-engine middleware implementing ethereum filter methods
ISC License
29 stars 38 forks source link

deps: @metamask/eth-block-tracker@^9.0.3->^10.0.0 #176

Closed legobeat closed 1 month ago

legobeat commented 2 months ago

Blocked by

Blocking

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-block-tracker@10.0.0 None 0 64.5 kB lgbot
npm/@metamask/eth-json-rpc-middleware@13.0.0 None 0 0 B
npm/@metamask/eth-json-rpc-provider@4.1.1 None 0 87.2 kB metamaskbot
npm/@metamask/json-rpc-engine@9.0.1 None 0 189 kB metamaskbot
npm/@metamask/rpc-errors@6.3.1 None 0 133 kB metamaskbot
npm/@metamask/superstruct@3.1.0 None 0 437 kB metamaskbot
npm/@metamask/utils@9.1.0 None 0 695 kB metamaskbot
npm/@types/bn.js@5.1.5 None 0 13.8 kB types
npm/bn.js@5.2.1 None 0 99 kB fanatid

🚮 Removed packages: npm/@metamask/eth-block-tracker@9.0.3, npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/@metamask/eth-json-rpc-provider@3.0.2, npm/@metamask/json-rpc-engine@9.0.0, npm/@metamask/rpc-errors@6.3.0, npm/@metamask/superstruct@3.0.0, npm/@metamask/utils@8.5.0, npm/@types/bn.js@4.11.6, npm/bn.js@4.12.0

View full report↗︎

socket-security[bot] commented 1 month ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

legobeat commented 1 month ago
@SocketSecurity ignore npm/@metamask/eth-block-tracker@10.1.0

new author ok

legobeat commented 1 month ago

@kanthesha @cryptodev-2s : Upgrading from @metamask/eth-block-tracker 10.0.0 to 10.1.0 is causing a regression: https://github.com/MetaMask/eth-json-rpc-filters/actions/runs/10013679322/job/27681824164?pr=176

# LogFilter - basic
Error: PollingBlockTracker - encountered an error while attempting to update latest block:
TypeError: this._provider.request is not a function
    at PollingBlockTracker._fetchLatestBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:275:43)
    at PollingBlockTracker._updateLatestBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:258:36)
    at PollingBlockTracker._updateAndQueue (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:292:18)
    at PollingBlockTracker._start (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:249:10)
    at PollingBlockTracker._maybeStart (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:166:10)
    at PollingBlockTracker._onNewListener (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:146:12)
    at safeApply (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/safe-event-emitter/index.ts:10:13)
    at PollingBlockTracker.emit (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/safe-event-emitter/index.ts:63:7)
    at _addListener (node:events:560:14)
    at PollingBlockTracker.addListener (node:events:609:10)
    at PollingBlockTracker.once (node:events:653:8)
    at /home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:50:50
    at new Promise (<anonymous>)
    at Object.trackNextBlock (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:50:12)
    at deployLogEchoContract (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/test/util.js:149:15)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at PollingBlockTracker._updateAndQueue (/home/runner/work/eth-json-rpc-filters/eth-json-rpc-filters/node_modules/@metamask/eth-block-tracker/src/PollingBlockTracker.ts:294:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: PollingBlockTracker - encountered an error while attempting to update latest block: