search

MetaMask / eth-json-rpc-filters

json-rpc-engine middleware implementing ethereum filter methods
ISC License
30 stars 38 forks source link

chore: update nodejs version #74

Closed mikesposito closed 1 year ago

mikesposito commented 1 year ago

Fixes #16613

mikesposito commented 1 year ago

The CI matrix in workflows/build-test.yml still runs v12.

I removed the v12 from the build matrix.

@legobeat @adonesky1 Currently, the extension is using Node v16, and we might want to update it soon to the latest LTS (v18): do you think it would make more sense to update this package to v16 or directly to v18?

mcmire commented 1 year ago

Just a thought: We can add support for other Node versions and set the development version of Node (.nvmrc) however we want, but from an engines perspective, we may want to keep the minimum version of Node at v14 as it hasn't hit end-of-life yet. This follows what our module template is doing.