MetaMask / eth-json-rpc-filters

json-rpc-engine middleware implementing ethereum filter methods
ISC License
30 stars 38 forks source link

devDeps: replace ganache-core v2 with ganache-cli v6 #99

Closed legobeat closed 11 months ago

socket-security[bot] commented 1 year ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ganache-cli 6.12.2 filesystem, shell, environment +1 45.4 MB truffle-cicd

🚮 Removed packages: ganache-core@2.13.2

socket-security[bot] commented 1 year ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: ganache-cli@6.12.2, semver@5.7.2, semver@7.5.4, which@1.3.1, sha.js@2.4.11

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

legobeat commented 11 months ago

Looks good. Are you planning to bump to Ganache 7 in a future PR to get rid of the ethereumjs-util dependency?

Possibly - it seems usage needs to be updated for it, though.

legobeat commented 11 months ago
@SocketSecurity ignore ganache-cli@6.12.2
@SocketSecurity ignore semver@5.7.2
@SocketSecurity ignore semver@7.5.4
@SocketSecurity ignore which@1.3.1
@SocketSecurity ignore sha.js@2.4.11

ganache-cli legacy bin script confusion