search

MetaMask / eth-json-rpc-middleware

Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine
ISC License
179 stars 88 forks source link

[fetch] Update list of retriable errors #212

Open Gudahtt opened 1 year ago

Gudahtt commented 1 year ago

We should analyze errors that we're seeing in production, and update our list of retriable errors to include all expected transient error scenarios.

We may need to improve the "retriable error" detection to consider more than just the message. For example, we may want to take into consideration the response headers or status code as well.

mcmire commented 4 months ago

Additional thoughts: Currently we handle 418 as a rate limit error. Perhaps we should also handle 429 as a rate limit error, and/or treat both 418 and 429 as retriable errors.