BREAKING: Drop support for Node.js v16,v21

[legobeat]

• Remove support for deprecated Node.js versions 16, 21
• Bump devDependency @types/node to match minimum Node.js version ^18.16
• Update Node versions in CI matrix
• Set .nvmrc to lts/* to align with metamask-module-template

Blocking

• 313

• 314

[socket-security[bot]]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/node@18.19.34	None	+1	2.04 MB	types

🚮 Removed packages: npm/@types/node@17.0.45

View full report↗︎

[MajorLift]

Hey I noticed that we're adding support for versions >=22 here.

In core (https://github.com/MetaMask/core/pull/3611) and metamask-module-template (https://github.com/MetaMask/metamask-module-template/pull/221), we only dropped v16 and didn't add support for v22.

Have we looked into whether there are any breaking changes in v22 we should prepare for? It looks like v21-22 support was previously included in the engines.node package.json field, but not in the github actions.

[legobeat]

Hey I noticed that we're adding support for versions >=22 here.

>=22 is not added but already included in existing/previous >=20.

Have we looked into whether there are any breaking changes in v22 we should prepare for?

I would expect that to be caught by tests..?

It looks like v21-22 support was previously included in the engines.node package.json field, but not in the github actions.

So, yes, we're not changing support contract (engines.node) wrt node v22 in this PR, but add test coverage for it here.