search

MetaMask / eth-json-rpc-middleware

Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine
ISC License
181 stars 88 forks source link

[14.x] fix: support ethermint's EIP712 implementation #333

Closed mtsitrin closed 1 month ago

mtsitrin commented 2 months ago

MM is broken since v12.1.1 for cosmos chains that use https://github.com/evmos/ethermint as EVM adapter.

Ethermint uses hard coded "cosmos" string as the VerifyingContract field, which is broken since validateVerifyingContract was introduced in MM.

This PR adds support to allow "cosmos" as the VerifyingContract value.

omritoptix commented 2 months ago

+1

testinginprod commented 2 months ago

+1

mtsitrin commented 2 months ago

@jpuri

Gudahtt commented 1 month ago

Thanks again for the contribution @mtsitrin ! I've just pushed a few minor changes to make this match the version of this that we merged into the main branch and shipped to production: https://github.com/MetaMask/eth-json-rpc-middleware/pull/334

Gudahtt commented 1 month ago

This has been published as @metamask/eth-json-rpc-middleware@14.0.2