Closed mikesposito closed 10 months ago
This commit introduced a bug with legacy transactions.
With @ethereumjs/rlp, RLP.encode(..) returns a Uint8Array, and Uint8Array.toString() does not return a hex value as we expect in the code.
@ethereumjs/rlp
RLP.encode(..)
Uint8Array
Uint8Array.toString()
This PR converts the returned Uint8Array into a Buffer, and then into a hex string.
Buffer
See https://github.com/MetaMask/metamask-extension/issues/22118
This commit introduced a bug with legacy transactions.
With
@ethereumjs/rlp
,RLP.encode(..)
returns aUint8Array
, andUint8Array.toString()
does not return a hex value as we expect in the code.This PR converts the returned
Uint8Array
into aBuffer
, and then into a hex string.See https://github.com/MetaMask/metamask-extension/issues/22118