MetaMask / eth-ledger-bridge-keyring

A wrapper around LedgerJS libraries, to support the KeyringController protocol used by MetaMask
ISC License
80 stars 93 forks source link

fix: invalid rlp data for legacy transactions #212

Closed mikesposito closed 10 months ago

mikesposito commented 10 months ago

This commit introduced a bug with legacy transactions.

With @ethereumjs/rlp, RLP.encode(..) returns a Uint8Array, and Uint8Array.toString() does not return a hex value as we expect in the code.

This PR converts the returned Uint8Array into a Buffer, and then into a hex string.

See https://github.com/MetaMask/metamask-extension/issues/22118