search

MetaMask / eth-method-registry

A JS library for getting Solidity method data from a four-byte method signature
ISC License
21 stars 13 forks source link

Migrate from `ethjs` to `ethers` #29

Open Gudahtt opened 3 years ago

Gudahtt commented 3 years ago

ethers is better maintained than ethjs, and we've been migrating many of our packages to use it. This should work equivalently.

This will be a breaking change because this will change public properties of the method registry class.

Gudahtt commented 3 years ago

I forgot to update the readme!

Edit: README has been updated; this should be good to go now.

brad-decker commented 1 year ago

@Gudahtt could this be revisted? I think removing ethjs across all the dependencies we maintain would be a solid move considering its staleness.

brad-decker commented 1 year ago

Happy to take this on, but i'd like more clarification on the issue you highlighted.

Gudahtt commented 1 year ago

I think what we want here is a type that represents an EIP-1193 provider. Then we can pass a provider that implements that interface (e.g. an Ethers provider) without being tied to a specific version of that specific library