Closed MajorLift closed 1 month ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/@metamask/keyring-api@8.0.1 | None | +1 |
259 kB | metamaskbot |
npm/@metamask/snaps-controllers@9.2.0 | Transitive: environment, filesystem, network | +59 |
14.7 MB | metamaskbot |
npm/@metamask/utils@9.1.0 | None | +3 |
729 kB | metamaskbot |
🚮 Removed packages: npm/@metamask/keyring-api@8.0.0, npm/@metamask/snaps-controllers@8.4.0, npm/@metamask/snaps-sdk@4.4.2
Actually, question — is it not possible to bump moduleResolution
in this repo?
@mcmire I'm seeing these errors when NodeNext
is enabled: https://github.com/MetaMask/eth-snap-keyring/pull/311#issuecomment-2155673290. Fixing them is a simple issue of augmenting the message.params
types, but it's weird that we'd see this from updating compiler options instead of the TypeScript version.
@mcmire Found the cause! https://github.com/MetaMask/eth-snap-keyring/issues/323#issuecomment-2160760043
This should be resolved by the new keyring-api release.
Explanation
As part of the Wallet Framework Team's OKR (Q2 2024 O3KR4) for upgrading TypeScript to v5.0+ in the core monorepo, we are updating dependencies of the core repo so that they generate builds and type declarations for both CJS and ESM.
This requirement applies to nested dependencies as well, so we are also replacing
superstruct
with the ESM-compatible fork@metamask/superstruct
in all core dependency packages.Description
superstruct
dependency with@metamask/superstruct
^3.0.0
.^3.1.0
superstruct
import statements with@metamask/superstruct
@metamask/utils
to^8.5.0
.^9.1.0
typescript
to~5.0.4
~module
andmoduleResolution
toNodeNext
.create-release-pr
github action, publish a new release containing these changes.References
Changelog