search

MetaMask / extension-provider

A module for allowing a WebExtension to access the web3 provider from an installed MetaMask instance
MIT License
67 stars 28 forks source link

Doesn't work in firefox - lost connection to MetaMask #1

Closed Powersource closed 4 years ago

Powersource commented 5 years ago

But it works in chrome. Errors:

MetamaskInpageProvider - lost connection to MetaMask index.js:126
Failed to connect to MetaMask: MetamaskInpageProvider - lost connection to MetaMask donate.js:14
_callee$/<
donate.js:14
EventEmitter.prototype.emit
events.js:81
logStreamDisconnectWarning
index.js:129
pump/destroys</<
index.js:75
f
once.js:25
destroyer/<
index.js:33
f
once.js:25
onfinish
index.js:30
EventEmitter.prototype.emit
events.js:96
finishMaybe
_stream_writable.js:630
afterWrite
_stream_writable.js:492
afterTick
index.js:40
Item.prototype.run
browser.js:153
drainQueue
browser.js:123
MetamaskInpageProvider - lost connection to MetaMask PublicConfigStore index.js:126
Failed to connect to MetaMask: MetamaskInpageProvider - lost connection to MetaMask PublicConfigStore donate.js:14
_callee$/<
donate.js:14
EventEmitter.prototype.emit
events.js:81
logStreamDisconnectWarning
index.js:129
pump/destroys</<
index.js:75
f
once.js:25
destroyer/<
index.js:33
f
once.js:25
onfinish
index.js:30
EventEmitter.prototype.emit
events.js:96
finishMaybe
_stream_writable.js:630
endWritable
_stream_writable.js:638
Writable.prototype.end
_stream_writable.js:594
onend
_stream_readable.js:577
g
events.js:165
EventEmitter.prototype.emit
events.js:96
endReadableNT
_stream_readable.js:1010
afterTickTwo
index.js:27
Item.prototype.run
browser.js:153
drainQueue
browser.js:123
MetamaskInpageProvider - lost connection to MetaMask RpcProvider index.js:126
Failed to connect to MetaMask: MetamaskInpageProvider - lost connection to MetaMask RpcProvider donate.js:14
_callee$/<
donate.js:14
EventEmitter.prototype.emit
events.js:81
logStreamDisconnectWarning
index.js:129
pump/destroys</<
index.js:75
f
once.js:25
destroyer/<
index.js:33
f
once.js:25
onfinish
index.js:30
EventEmitter.prototype.emit
events.js:96
finishMaybe
_stream_writable.js:630
endWritable
_stream_writable.js:638
Writable.prototype.end
_stream_writable.js:594
onend
_stream_readable.js:577
g
events.js:165
EventEmitter.prototype.emit
events.js:96
endReadableNT
_stream_readable.js:1010
afterTickTwo
index.js:27
Item.prototype.run
browser.js:153
drainQueue
browser.js:123

The Failed to connect to MetaMask errors are from us logging on provider.on('error'....

Our code is here https://github.com/SuperuserLabs/thankful/blob/06b8e8a0c047452973cd167280c07fa3763b50d1/src/lib/donate.js#L10 Still investigating this, but wanted to throw this up here already since we have a deadline tomorrow.

Powersource commented 5 years ago

It seems to be enough to change FIREFOX_ID in the config to "webextension@metamask.io". Will create a PR.

Powersource commented 5 years ago

https://github.com/MetaMask/metamask-extension-provider/pull/2