MetaMask / jazzicon

Jazzy deterministic identicons for a more entertaining future
https://metamask.github.io/jazzicon/
ISC License
76 stars 26 forks source link

Revert "Remove dependency on color lib and upgrade version to 2.1.0" #24

Open mcmire opened 1 month ago

mcmire commented 1 month ago

This reverts commit d923914fda6a8795f74c2e66134f73cd72070667.

It seems that the implementation of hueShift is slightly different in this commit than before and therefore produces slightly different colors as before. Reverting so that we can fix this bug.

socket-security[bot] commented 1 month ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/color@0.11.4 None +4 78.2 kB qix

View full report↗︎

socket-security[bot] commented 1 month ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/color-string@0.3.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

mcmire commented 1 month ago

@SocketSecurity ignore npm/color-string@0.3.0

New author is okay, I reviewed his profile and latest contributions on GitHub and he seems trustworthy.