Closed jmrossy closed 3 years ago
Looks good to me, happy to remove a dep and reduce bundle size! Will want to do a quick visual verification before pushing to npm, but otherwise looks safe.
Agreed, visual confirmation from another consumer of the lib would be good!
FWIW here's a quick confirmation from my own app:
Summary
This hoists up the little bit of color manipulation logic needed from the color library in order to remove that dependency. The bulk of jazzicon's bundle size came from color so this significantly reduced it (~20Kb reduction).
It also increases the major version number to mark the change.
Testing
Tested in Safari, Firefox, and Chrome (via https://celowallet.app) on known addresses and can confirm they render correctly.