MetaMask / key-tree

MIT License
49 stars 19 forks source link

Replace `@noble/ed25519` and `@noble/secp256k1` with `@noble/curves` #154

Closed Mrtenz closed 11 months ago

Mrtenz commented 11 months ago

This replaces @noble/ed25519 and @noble/secp256k1 with the alternative @noble/curves package. The ed25519 and secp256k1 packages have a new major version with doesn't work with CJS, and since the majority of our stack relies on CJS, we can't upgrade to them. The README for these packages mentions @noble/curves as a "safer and faster" replacement:

[...] some features were moved to noble-curves, which is even safer and faster drop-in replacement library with same API.

socket-security[bot] commented 11 months ago

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @scure/base@1.1.1