BREAKING: Make all APIs synchronous

MetaMask / key-tree

MIT License

49 stars 19 forks source link

BREAKING: Make all APIs synchronous #155

Closed Mrtenz closed 7 months ago

Mrtenz commented 11 months ago

Blocked by #154.

All of the APIs we use from @noble/curves are synchronous, meaning that we can make all functions in this package synchronous as well. This is a breaking change, because it changes the function signature for most functions.

Mrtenz commented 11 months ago

Synchronous APIs (this PR):

yarn test  71.31s user 3.66s system 248% cpu 30.143 total

Asynchronous APIs (#154):

yarn test  70.55s user 3.65s system 246% cpu 30.145 total

Current main branch:

yarn test  52.92s user 3.20s system 248% cpu 22.568 total