MetaMask / metamask-android-sdk

MetaMask SDK for Android
Other
41 stars 13 forks source link

Please make it possible to implement di library as an option #42

Closed amuyu closed 10 months ago

amuyu commented 11 months ago

It's currently mandatory for the di library to use Dagger-Hilt, but it would be great if developers could have the option to implement this part selectively.

For example, some apps might use Koin instead of Dagger-Hilt with the di library, or they might not use the di library at all. If we restrict it to only use Dagger-Hilt, it might be challenging to use.

It would be a good idea to separate it into a multi-module structure. Like this,

christopherferreira9 commented 10 months ago

Hi @amuyu ! Thank you for your suggestion, we are taking it in consideration.

bigman212 commented 10 months ago

@amuyu I was able to connect and init Metamask Android SDK using Koin without connecting any Hilt libs. You can manually create ApplicationRepository and Ethereum class by yourself.

amuyu commented 10 months ago

Thank you for response @bigman212. Even if i don't use Hilt or viewModel, I still need to add the necessary dependencies to use Metamask. That's why I thought it would be beneficial if this part could be separated.

elefantel commented 10 months ago

Hey @amuyu , thanks for reporting this. It was part of our sprint work, we have implemented it. Check latest main branch, you should not need to add hilt dependency anymore. You can opt not to use any dependency manager at all or use any of your choosing.

Just a note that as of posting this response, version 0.2.1 containing these changes has not been published on Maven but only on main branch on the repo. So you can still pull main and see the changes