MetaMask / metamask-android-sdk

MetaMask SDK for Android
Other
41 stars 13 forks source link

[Bug]: request account connect pop twice #94

Closed philos3 closed 6 months ago

philos3 commented 6 months ago

Provide environment information

error

MetaMask Android SDK Version

io.metamask.androidsdk:metamask-android-sdk:0.5.0

MetaMask Mobile app Version

no

Android Version

android 13

Describe the Bug

image image

when i call ethereum.connect , it shows two identical pop-ups as below window image

console log: MM_ANDROID_SDK(12200): Ethereum:: Sending request EthereumRequest(id=1708423891739, method=eth_requestAccounts, params=null) D/MM_ANDROID_SDK(12200): CommunicationClient:: sendRequest - not yet connected to metamask, binding service first D/MM_ANDROID_SDK(12200): CommunicationClient:: Queued job D/MM_ANDROID_SDK(12200): CommunicationClient:: Binding service D/MM_ANDROID_SDK(12200): Ethereum:: Sending request EthereumRequest(id=1708423891765, method=eth_chainId, params=null) D/MM_ANDROID_SDK(12200): CommunicationClient:: sendRequest - not yet connected to metamask, binding service first D/MM_ANDROID_SDK(12200): CommunicationClient:: Queued job D/MM_ANDROID_SDK(12200): CommunicationClient:: Binding service I/flutter (12200): HttpTaskManager进入AppLifecycleState.inactive D/MM_ANDROID_SDK(12200): CommunicationClient:: Service connected ComponentInfo{io.metamask/io.metamask.nativesdk.MessageService} D/MM_ANDROID_SDK(12200): CommunicationClient:: Initiating key exchange

Expected Behavior

pop window one time

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

No response

To Reproduce

ethereum.connect

elefantel commented 6 months ago

Hi @philos3 thanks for the issue! The issue of the connect prompt showing up twice has been fixed in the metamask wallet version 7.16. It's already on the AppStore but still at 2% rollout as of writing of this message.

philos3 commented 6 months ago

what is the fix version of metamask-android-sdk

elefantel commented 6 months ago

@philos3 there were no changes required pertaining to this issue from the android sdk side.