Decision: Whether to Set Node Engine Version in MetaMask Design System Packages

[georgewrmarshall]

Description

We need to make a decision regarding whether to set the node engine version explicitly in the package.json files for the MetaMask Design System packages. This will involve weighing the pros and cons of this decision, particularly how it aligns with the MetaMask engineering organization's standards and practices.

 "engines": {
    "node": "^18.18 || >=20"
  },

Technical Details

• Investigate the current policies and conventions used by the MetaMask engineering organization regarding node engine version specification.
• Evaluate the potential benefits of enforcing a specific node version, such as ensuring compatibility across environments.
• Consider possible downsides, such as limiting flexibility for contributors using different versions of Node.js.
• Research if any existing MetaMask repositories or other relevant projects have similar requirements.
• Identify any required tooling or configuration changes if a node version is enforced (e.g., .nvmrc files or engines field in package.json).

Acceptance Criteria

• A well-documented decision on whether or not to set the node engine version in the Design System packages.
• The decision is aligned with MetaMask engineering best practices and the needs of the project.
• If the decision is made to set a node version, ensure that all relevant package.json files are updated and that any required tooling (e.g., .nvmrc) is also configured.

[georgewrmarshall]

I think we would to set minimum node versions to align with other MetaMask monorepos

"engines": { "node": "^18.18 || >=20" },