chore: fix publish preview build script

georgewrmarshall commented 3 weeks ago

Description

This PR updates the publish-preview-build script to enable publishing test versions of metamask-design-system monorepo packages. The current script and associated GitHub Action are not functioning as expected, which prevents the publication of preview builds. By updating the script, this PR aims to ensure preview builds are published successfully, enabling efficient testing of monorepo package updates.

Manual testing steps

Trigger the publish-preview-build workflow on a PR by commenting @metamaskbot publish-preview.
Check GitHub Actions logs to confirm that the workflow completes without errors.
Verify that a test version of the metamask-design-system package is published.
Confirm that the version is accessible and functional for testing.

Screenshots/Recordings

Before

Currently, @metamaskbot publish-preview is failing. You can try running it on this test PR.

https://github.com/user-attachments/assets/be2d3cd2-530d-4825-b512-7a74f92e2f61

After

https://github.com/user-attachments/assets/65c27efe-e079-4850-9e66-c42b952be31b

https://github.com/user-attachments/assets/be833baa-46f0-47ff-936f-db91e341ea3f

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs.
[x] I’ve completed the PR template to the best of my ability.
[x] I’ve included tests if applicable.
[x] I’ve documented my code using JSDoc format if applicable.
[x] I’ve applied the correct labels for this PR (see labeling guidelines).

Pre-merge reviewer checklist

[ ] I’ve manually tested the PR by pulling and building the branch, running the publish-preview-build script, and confirming functionality.
[ ] I confirm that this PR addresses all acceptance criteria and includes the necessary testing evidence such as logs, screenshots, or recordings.

georgewrmarshall commented 2 weeks ago

@metamaskbot publish-preview

georgewrmarshall commented 2 weeks ago

@metamaskbot publish-preview

georgewrmarshall commented 2 weeks ago

@metamaskbot publish-preview

georgewrmarshall commented 2 weeks ago

@metamaskbot publish-preview

github-actions[bot] commented 2 weeks ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

``` { "@metamask-previews/design-system-react": "0.0.0-preview.909f2e9", "@metamask-previews/design-system-react-native": "0.0.0-preview.909f2e9", "@metamask-previews/design-system-tailwind-preset": "0.0.0-preview.909f2e9" } ```

georgewrmarshall commented 2 weeks ago

@metamaskbot publish-preview

github-actions[bot] commented 2 weeks ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

``` { "@metamask-previews/design-system-react": "0.0.0-preview.52473ea", "@metamask-previews/design-system-react-native": "0.0.0-preview.52473ea", "@metamask-previews/design-system-tailwind-preset": "0.0.0-preview.52473ea" } ```

brianacnguyen commented 2 weeks ago

@georgewrmarshall can you add a video to prove that Confirm that the version is accessible and functional for testing.?

georgewrmarshall commented 2 weeks ago

Great suggestion @brianacnguyen! Done.

MetaMask / metamask-design-system