MetaMask / metamask-docs

Developer documentation for MetaMask
https://docs.metamask.io
Apache License 2.0
647 stars 929 forks source link

Update design-guidelines.md #1287

Closed eriknson closed 3 months ago

eriknson commented 4 months ago

Minor snaps design guidelines update

github-actions[bot] commented 4 months ago

Preview published: eriknson-patch-1

alexandratran commented 4 months ago

@eriknson Since we refer to it as an "icon" in the tutorial, which seems to be a more common term than "avatar," can we update the term to "icon" on this page? Could you also update the images install.png and dialog.png to use "icon" instead of "avatar"?

eriknson commented 4 months ago

@eriknson Since we refer to it as an "icon" in the tutorial, which seems to be a more common term than "avatar," can we update the term to "icon" on this page? Could you also update the images install.png and dialog.png to use "icon" instead of "avatar"?

No, the more common term for this context is avatar, so let's use that everywhere imo.

alexandratran commented 4 months ago

@mario-christopher @eriknson Can we get agreement on avatar vs. icon? For me it seems like an avatar is a type of icon typically representing a user, not a brand or application. But I don't have a strong opinion on this.

And if we change this in the Snaps docs, should we also change the Wallet docs to "display a dapp avatar"?

eriknson commented 3 months ago

@alexandratran

I just ran this by @Montoya and we agreed to use Snap icon or just icon (if it's already been introduced on the same page) so nvm above re: Avatar

alexandratran commented 3 months ago

@eriknson Sounds good. Can you update the install.png and dialog.png images in this section of the design guidelines to use "icon" instead of "avatar," or provide access to the raw files so I can update them? I'll go ahead and update the rest of the page.

github-actions[bot] commented 3 months ago

Preview published: eriknson-patch-1

github-actions[bot] commented 3 months ago

Preview published: eriknson-patch-1