MetaMask / metamask-docs

Developer documentation for MetaMask
https://docs.metamask.io
Apache License 2.0
661 stars 946 forks source link

Document eth_sign discontinuation #1319

Closed alexandratran closed 4 months ago

alexandratran commented 4 months ago

Description

Update eth_sign description to note that it is no longer supported.

Issue(s) fixed

Fixes #1313

Preview

https://docs.metamask.io/1313-eth-sign-discontinuation/wallet/concepts/signing-methods/#eth_sign

Checklist

Complete this checklist before merging your PR:

github-actions[bot] commented 4 months ago

Preview published: 1313-eth-sign-discontinuation

vandan commented 4 months ago

Only thought is to try and add a reference to the associated MIP for this change. It's still an outstanding PR that needs to be reviewed/merged - should happen very soon: https://github.com/MetaMask/metamask-improvement-proposals/pull/42

github-actions[bot] commented 4 months ago

Preview published: 1313-eth-sign-discontinuation

alexandratran commented 4 months ago

Added in a link for MIP-3, but the file is not ready due to autonumbering issues: https://github.com/MetaMask/metamask-improvement-proposals/blob/main/MIPs/mip-x.md.

Once that file is updated to mip-3.md, this PR should be ready to go.

github-actions[bot] commented 4 months ago

Preview published: 1313-eth-sign-discontinuation