MetaMask / metamask-docs

Developer documentation for MetaMask
https://docs.metamask.io
Apache License 2.0
636 stars 908 forks source link

Add how-to page for `initialConnections` #1322

Closed ziad-saab closed 1 month ago

ziad-saab commented 1 month ago

Description

Add a how-to page for initialConnections

Issue(s) fixed

Fixes #

Preview

Checklist

Complete this checklist before merging your PR:

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

Montoya commented 1 month ago

Hi @ziad-saab, I did not intend to remove the section on initialConnections from the permissions page and move it to a how to page. initialConnections is part of Snaps permissions and should remain in the permissions section as it is documented. What I wanted to do was have a longer how to guide on how to use this unique permission with example dapp code and some way to convey how the flow changes when the dapp is able to auto-connect.

Please revert the permissions page and flesh out the how to page.

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

alexandratran commented 1 month ago

@Montoya Sorry, I was the one who moved it from the Permissions reference, since the added content seemed to be exactly the same and I wanted to avoid duplication. I've now added it back to Permissions, and added an example link to the How to page. Let me know if there's a specific way you want to flesh out the How to page further (is there a particular code sample from the dapp package we should include?)

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature

github-actions[bot] commented 1 month ago

Preview published: zs/initialconnections-feature