Closed TrofimovAnton85 closed 1 month ago
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
Preview published: feat-reference-pages
When pulling parameter information from the Open RPC spec, can you display the property name instead of the
title
value for each parameter? I.e., the information in the green box instead of the red box in the following screenshot:The property names consistently use the camel case version of the parameter name, whereas the
title
values are inconsistent, leading to inconsistently formatted parameters displayed:Can you also use code formatting for all the parameter names and the page title (
eth_call
)?
@alexandratran thanks! Fixed & committed -
at this stage, I need to "mirror" the functionality of the current MM plugin for RPС reference pages (and this approach is used there). But when I implement the form, I will check your option. Thanks!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
metamask-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 12, 2024 11:14am |
metamask-docs-hftx | ❌ Failed (Inspect) | Jun 12, 2024 11:14am |
Preview published: feat-reference-pages
Preview published: feat-reference-pages
I suggest using code formatting for the method name (
eth_call
) and the parameters (type
,nonce
, etc). Otherwise, LGTM.(I might have to approve again if more commits are added.)
@alexandratran Thanks! Please approve again. *For now, I left the formatting for the name of the method/parameters as in the design (but I think after implementing the second part, we can think about it)
Description
How to test:
Go to the test page for the
eth_call
method - https://docs.metamask.io/feat-reference-pages/wallet/reference/new-reference/ and check the main layout (description, label, request/response sections)Links:
JIRA Issue Figma